Fix workflows #46

juancwu · 2024-11-22T19:57:12Z

workflows seem to behave as expected now, and its good to merge.

Will need to force merge this even though backend test are not passing. Fixing the tests are outside of the scope of this PR.

Backend tests were failing before this PR and were not caught because the workflow check was not failing properly.

github-actions · 2024-11-25T04:30:28Z

Test Results ❌

Status: failure
Coverage: 29.8%
OS: Linux

❌ Test Failures

--- FAIL: TestProjectCommentEndpoints (0.02s)
  
--- FAIL: TestProjectCommentEndpoints/create_comment (0.00s)
  

Error Details:
req_validator_test.go:104: {"test_field":true}
      
=== RUN   TestRequestBodyValidator/Invalid_request_body_-_validation_error
{"level":"error","error":"Key: 'testStruct.TestField' Error:Field validation for 'TestField' failed on the 'required' tag","time":"2024-11-26T04:17:38Z","message":"Validation error"}
  req_validator_test.go:104: {"message":"Internal Server Error"}
      
=== RUN   TestRequestBodyValidator/Empty_request_body
{"level":"error","error":"Key: 'testStruct.TestField' Error:Field validation for 'TestField' failed on the 'required' tag","time":"2024-11-26T04:17:38Z","message":"Validation error"}
  req_validator_test.go:104: {"message":"Internal Server Error"}
      
=== RUN   TestRequestBodyValidator/Invalid_JSON_format
  req_validator_test.go:104: {"message":"Invalid request body: code=400, message=Syntax error: offset=21, error=invalid character 'i' looking for beginning of value, internal=invalid character 'i' looking for beginning of value"}
      
=== RUN   TestRequestBodyValidator/Wrong_type_in_JSON
  req_validator_test.go:104: {"message":"Invalid request body: code=400, message=Unmarshal type error: expected=bool, got=string, field=test_field, offset=29, internal=json: cannot unmarshal string into Go struct field testStruct.test_field of type bool"}
      
--- PASS: TestRequestBodyValidator (0.00s)
  --- PASS: TestRequestBodyValidator/Valid_request_body (0.00s)
  --- PASS: TestRequestBodyValidator/Invalid_request_body_-_validation_error (0.00s)
  --- PASS: TestRequestBodyValidator/Empty_request_body (0.00s)
  --- PASS: TestRequestBodyValidator/Invalid_JSON_format (0.00s)
  --- PASS: TestRequestBodyValidator/Wrong_type_in_JSON (0.00s)
PASS
coverage: 29.8% of statements
ok  	github.com/KonferCA/NoKap/internal/middleware	0.008s	coverage: 29.8% of statements
=== RUN   TestAuth
=== RUN   TestAuth/signup
{"level":"info","method":"POST","path":"/api/v1/auth/signup","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
{"level":"info","X-Request-Id":"","Content-Type":"application/json","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
=== RUN   TestAuth/duplicate_email
{"level":"info","method":"POST","path":"/api/v1/auth/signup","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
{"level":"error","error":"code=409, message=email already registered","X-Request-Id":"","Content-Type":"","Content-Length":"","time":"2024-11-26T04:17:39Z"}
{"level":"info","X-Request-Id":"","Content-Type":"","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
{"level":"warn","error":"code=409, message=email already registered","request_id":"","method":"POST","path":"/api/v1/auth/signup","status":409,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
=== RUN   TestAuth/signin
{"level":"info","method":"POST","path":"/api/v1/auth/signin","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
{"level":"info","X-Request-Id":"","Content-Type":"application/json","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
=== RUN   TestAuth/invalid_credentials
{"level":"info","method":"POST","path":"/api/v1/auth/signin","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
{"level":"error","error":"code=401, message=invalid credentials","X-Request-Id":"","Content-Type":"","Content-Length":"","time":"2024-11-26T04:17:39Z"}
{"level":"info","X-Request-Id":"","Content-Type":"","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
{"level":"warn","error":"code=401, message=invalid credentials","request_id":"","method":"POST","path":"/api/v1/auth/signin","status":401,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
--- PASS: TestAuth (0.27s)
  --- PASS: TestAuth/signup (0.07s)
  --- PASS: TestAuth/duplicate_email (0.00s)
  --- PASS: TestAuth/signin (0.07s)
  --- PASS: TestAuth/invalid_credentials (0.07s)
=== RUN   TestGlobalErrorHandler
=== RUN   TestGlobalErrorHandler/http_error
{"level":"warn","error":"code=400, message=bad request","request_id":"","method":"GET","path":"/","status":400,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
=== RUN   TestGlobalErrorHandler/generic_error
{"level":"error","error":"code=500, message=something went wrong","request_id":"","method":"GET","path":"/","status":500,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
=== RUN   TestGlobalErrorHandler/validation_error
{"level":"warn","error":"Key: 'TestStruct.Email' Error:Field validation for 'Email' failed on the 'email' tag\nKey: 'TestStruct.Age' Error:Field validation for 'Age' failed on the 'gt' tag","request_id":"","method":"GET","path":"/","status":400,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
=== RUN   TestGlobalErrorHandler/with_request_id
{"level":"warn","error":"code=400, message=bad request","request_id":"test-123","method":"GET","path":"/","status":400,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
--- PASS: TestGlobalErrorHandler (0.00s)
  --- PASS: TestGlobalErrorHandler/http_error (0.00s)
  --- PASS: TestGlobalErrorHandler/generic_error (0.00s)
  --- PASS: TestGlobalErrorHandler/validation_error (0.00s)
  --- PASS: TestGlobalErrorHandler/with_request_id (0.00s)
=== RUN   TestGetSystemInfo
--- PASS: TestGetSystemInfo (0.00s)
=== RUN   TestHealthCheckHandler
=== RUN   TestHealthCheckHandler/healthy_system
=== RUN   TestHealthCheckHandler/unhealthy_system
--- PASS: TestHealthCheckHandler (0.01s)
  --- PASS: TestHealthCheckHandler/healthy_system (0.00s)
  --- PASS: TestHealthCheckHandler/unhealthy_system (0.00s)
=== RUN   TestProjectCommentEndpoints
{"level":"info","method":"POST","path":"/api/v1/companies","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
{"level":"info","X-Request-Id":"","Content-Type":"application/json","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
  project_comment_test.go:75: Company creation response: {
        "ID": "fa04a9d2-fdd3-48ae-b1a9-b77bcc4293f6",
        "OwnerUserID": "4b1672c8-7048-4785-ac25-ef05755cfd7f",
        "Name": "Test Company",
        "Description": "Test Company Description",
        "IsVerified": false,
        "CreatedAt": "2024-11-26T04:17:39.302869Z",
        "UpdatedAt": "2024-11-26T04:17:39.302869Z",
        "DeletedAt": null
      }
{"level":"info","method":"POST","path":"/api/v1/projects","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
Creating project with params: company_id=fa04a9d2-fdd3-48ae-b1a9-b77bcc4293f6, title=Test Project, status=draft
Created project: {ID:278de23d-c3b2-46b2-8931-f523aea90380 CompanyID:fa04a9d2-fdd3-48ae-b1a9-b77bcc4293f6 Title:Test Project Description:0xc0004d4370 Status:draft CreatedAt:{Time:2024-11-26 04:17:39.304093 +0000 UTC InfinityModifier:finite Valid:true} UpdatedAt:{Time:2024-11-26 04:17:39.304093 +0000 UTC InfinityModifier:finite Valid:true}}
{"level":"info","X-Request-Id":"","Content-Type":"application/json","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
  project_comment_test.go:103: Project creation response: {
        "ID": "278de23d-c3b2-46b2-8931-f523aea90380",
        "CompanyID": "fa04a9d2-fdd3-48ae-b1a9-b77bcc4293f6",
        "Title": "Test Project",
        "Description": "Test Description",
        "Status": "draft",
        "CreatedAt": "2024-11-26T04:17:39.304093Z",
        "UpdatedAt": "2024-11-26T04:17:39.304093Z"
      }
=== RUN   TestProjectCommentEndpoints/create_comment
{"level":"info","method":"POST","path":"/api/v1/projects/278de23d-c3b2-46b2-8931-f523aea90380/comments","X-Request-Id":"","X-Real-Ip":"","Content-Type":"application/json","Content-Length":"","remote_addr":"192.0.2.1:1234","user_agent":"","real_ip":"192.0.2.1","time":"2024-11-26T04:17:39Z","message":"New request!"}
{"level":"error","error":"code=400, message=Missing project ID :(","X-Request-Id":"","Content-Type":"","Content-Length":"","time":"2024-11-26T04:17:39Z"}
{"level":"info","X-Request-Id":"","Content-Type":"","Content-Length":"","time":"2024-11-26T04:17:39Z","message":"Requested processed."}
{"level":"warn","error":"code=400, message=Missing project ID :(","request_id":"","method":"POST","path":"/api/v1/projects/278de23d-c3b2-46b2-8931-f523aea90380/comments","status":400,"user_agent":"","time":"2024-11-26T04:17:39Z","message":"request error"}
  project_comment_test.go:129: Create comment response: {
        "status": 400,
        "message": "Missing project ID :("
      }
  project_comment_test.go:130: 
      	Error Trace:	/home/runner/work/SPUR/SPUR/backend/internal/server/project_comment_test.go:130
      	Error:      	Not equal: 
      	            	expected: 201
      	            	actual  : 400
      	Test:       	TestProjectCommentEndpoints/create_comment
project_comment_test.go:135: 
      	Error Trace:	/home/runner/work/SPUR/SPUR/backend/internal/server/project_comment_test.go:135
      	Error:      	Not equal: 
      	            	expected: string("278de23d-c3b2-46b2-8931-f523aea90380")
      	            	actual  : <nil>(<nil>)
      	Test:       	TestProjectCommentEndpoints/create_comment
project_comment_test.go:136: 
      	Error Trace:	/home/runner/work/SPUR/SPUR/backend/internal/server/project_comment_test.go:136
      	Error:      	Not equal: 
      	            	expected: string("This is a test comment")
      	            	actual  : <nil>(<nil>)
      	Test:       	TestProjectCommentEndpoints/create_comment
project_comment_test.go:145: List comments response: {
        "status": 400,
        "message": "Missing project ID :("
      }
  project_comment_test.go:146: 
      	Error Trace:	/home/runner/work/SPUR/SPUR/backend/internal/server/project_comment_test.go:146
      	Error:      	Not equal: 
      	            	expected: 200
      	            	actual  : 400
      	Test:       	TestProjectCommentEndpoints/list_comments
project_comment_test.go:150: 
      	Error Trace:	/home/runner/work/SPUR/SPUR/backend/internal/server/project_comment_test.go:150
      	Error:      	Received unexpected error:
      	            	json: cannot unmarshal object into Go value of type []map[string]interface {}
      	Test:       	TestProjectCommentEndpoints/list_comments
project_comment_test.go:151: 
      	Error Trace:	/home/runner/work/SPUR/SPUR/backend/internal/server/project_comment_test.go:151
      	Error:      	"[]" should have 1 item(s), but has 0
      	Test:       	TestProjectCommentEndpoints/list_comments

Test Details

Triggered by: @juancwu
Commit: 09302eb
Branch: refs/pull/46/merge
Workflow: .github/workflows/test-backend.yml

AmirAgassi

lgtm

juancwu added the enhancement New feature or request label Nov 22, 2024

juancwu requested review from AmirAgassi and aidantrabs November 22, 2024 19:57

juancwu self-assigned this Nov 22, 2024

juancwu linked an issue Nov 22, 2024 that may be closed by this pull request

Combine workflows for test and preview deployment #45

Closed

juancwu and others added 22 commits November 24, 2024 21:31

move workflows out of their own folders

6c2f539

combine test workflows

d42fdb9

redefined working directory

34e301a

remove shell from test workflow

32172a5

fix working directory

371df73

echo pwd

eb900a5

update

e25e71d

update

5abd7aa

add working-directory to all steps

ebcd92d

update

8e6f20e

update

07bf171

update

83f8014

update

171c3b7

update

c229d35

update

7f8c775

update

bdfbc4a

update

33a5f45

update

73bdddc

update

9778fb0

update

422a60e

revert

a670763

separate test workflows

b81bc2a

juancwu force-pushed the feat/45/combine-workflows branch from 16b263a to b81bc2a Compare November 25, 2024 02:32

juancwu added 2 commits November 24, 2024 21:53

update frontend page title

09842b1

remove cache

23c994e

juancwu added 6 commits November 24, 2024 22:01

ls

d1b9cff

change directory

80d0966

cd before running cmd

d009716

update backend test with cd

70a5aed

update backend readme with specific version for tooling

a289367

update backend test flow

02cbf0e

juancwu added 3 commits November 24, 2024 23:32

update backend test actions version

c741c4b

update backend test flow

0aa4686

remove cache

8ce2858

juancwu changed the title ~~Feat/45/combine workflows~~ Fix workflows Nov 25, 2024

juancwu added the bug Something isn't working label Nov 25, 2024

juancwu added 12 commits November 25, 2024 23:05

update deploy flows

e167518

set pipeline code

2292291

remove pr commenting after backend test

71de4d7

add back setting exit code

bbf402f

remove coverage report upload

f336f7a

check for exit code

d8e6972

remove continue on error

9c2fecf

generate backend html coverage

043e3f5

move the coverage to html to test step

1252ba6

separete coverage html

4f859bf

remove comment pr

468cc57

output test coverage

1e772b5

AmirAgassi approved these changes Nov 26, 2024

View reviewed changes

juancwu merged commit 942438d into main Nov 26, 2024
4 of 5 checks passed

juancwu deleted the feat/45/combine-workflows branch November 26, 2024 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix workflows #46

Fix workflows #46

juancwu commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

AmirAgassi left a comment

Fix workflows #46

Fix workflows #46

Conversation

juancwu commented Nov 22, 2024 • edited Loading

github-actions bot commented Nov 25, 2024 • edited Loading

Test Results ❌

AmirAgassi left a comment

Choose a reason for hiding this comment

juancwu commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading